RcppArmadillo 15.0.1-1 with Armadillo 15.0.1 (and Armadillo 14.6.3 under C++11) #473
+208,261
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds fallback compilation using 14.6.2 installed in inst/include/legacy/ otherwise current version is used (requiring C++14 or newer) from inst/include/current
eddelbuettel
force-pushed
the
feature/arma_15.0
branch
from
9b69f73 to
b483312
Compare
eddelbuettel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471
Closes #474
As described in #471, Armadillo upstream switched to C++14.
That is not viable at CRAN as minimal compilation standard as well over 200 packages explicitly set C++11 and need to switched over time. So as a transition, we also include the (most recent) version of the 14.6.* branch, currently 14.6.3, as a fallback that is used if C++11 compilation is detected.
That scheme has been tested across multiple rounds of reverse dependencies and works. 1 2
Footnotes
We see one regression in one package (also seen with another compiler at CRAN) that appears fully unrelated to the Armadillo changes, but possibly related to C++14. We contacted upstream as we think the issue it at their end and plan to convince CRAN that this not a regression, ↩
The regression revealed a real bug (noted in Regression with Armadillo 15.0.0 -- and 14.6.* under Intel #474) leading to release 15.0.1. Yay for reverse-dependency checks. ↩